Add ignore ssl error (#145)

* add ignore ssl
* build and update docs
* keep the upstream formatting/indentation

README.md

@@ -45,8 +45,10 @@ jobs:
 |httpsCert| Client Certificate as string ||
 |httpsKey| Client Certificate Key as string ||
 |responseFile| Persist the response data to the specified file path ||
+|maskResponse| If set to true, the response will be masked in the logs of the action |'false'|
 |retry| optional amount of retries if the request is failing, does not retry if the status code is ignored ||
 |retryWait| time between each retry in millseconds | 3000 |
+|ignoreSsl| ignore ssl verify (rejectUnauthorized: false) | false |
 
 ### Response
 
@@ -99,4 +101,4 @@ Optionen:
       --bearerToken    bearer token without Bearer prefix, added as
                        Authorization header                            [string]
       --timeout        request timeout                                 [number] [default: 5000]
-```
+```

action.yml

@@ -29,7 +29,7 @@ inputs:
         description: 'Auth Password'
         required: false
     timeout:
-        description: 'Request Timeout in Sec'
+        description: 'Request Timeout in milliseconds'
         required: false
         default: '5000'
     bearerToken:
@@ -69,11 +69,14 @@ inputs:
     retryWait:
         description: 'wait time between retries in milliseconds'
         required: false
+    ignoreSsl:
+        description: 'ignore ssl verify (rejectUnauthorized: false)'
+        default: 'false'
 outputs:
     response:
         description: 'HTTP Response Content'
     headers:
         description: 'HTTP Response Headers'
 runs:
-    using: 'node16'
+    using: 'node20'
     main: 'dist/index.js'

package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "http-request-action",
-  "version": "1.14.1",
+  "version": "1.14.2",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "http-request-action",
-      "version": "1.14.1",
+      "version": "1.14.2",
       "license": "MIT",
       "dependencies": {
         "@actions/core": "^1.10.1"
@@ -87,12 +87,12 @@
       "dev": true
     },
     "node_modules/axios": {
-      "version": "1.6.2",
-      "resolved": "https://registry.npmjs.org/axios/-/axios-1.6.2.tgz",
-      "integrity": "sha512-7i24Ri4pmDRfJTR7LDBhsOTtcm+9kjX5WiY1X3wIisx6G9So3pfMkEiU7emUBe46oceVImccTEM3k6C5dbVW8A==",
+      "version": "1.6.8",
+      "resolved": "https://registry.npmjs.org/axios/-/axios-1.6.8.tgz",
+      "integrity": "sha512-v/ZHtJDU39mDpyBoFVkETcd/uNdxrWRrg3bKpOKzXFA6Bvqopts6ALSMU3y6ijYxbw2B+wPrIv46egTzJXCLGQ==",
       "dev": true,
       "dependencies": {
-        "follow-redirects": "^1.15.0",
+        "follow-redirects": "^1.15.6",
         "form-data": "^4.0.0",
         "proxy-from-env": "^1.1.0"
       }
@@ -166,9 +166,9 @@
       }
     },
     "node_modules/follow-redirects": {
-      "version": "1.15.3",
-      "resolved": "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.15.3.tgz",
-      "integrity": "sha512-1VzOtuEM8pC9SFU1E+8KfTjZyMztRsgEfwQl44z8A25uy13jSzTj6dyK2Df52iV0vgHCfBwLhDWevLn95w5v6Q==",
+      "version": "1.15.6",
+      "resolved": "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.15.6.tgz",
+      "integrity": "sha512-wWN62YITEaOpSK584EZXJafH1AGpO8RVgElfkuXbTOrPX4fIfOyEpW/CsiNd8JdYrAoOvafRTOEnvsO++qCqFA==",
       "dev": true,
       "funding": [
         {
@@ -288,9 +288,9 @@
       }
     },
     "node_modules/undici": {
-      "version": "5.27.2",
-      "resolved": "https://registry.npmjs.org/undici/-/undici-5.27.2.tgz",
-      "integrity": "sha512-iS857PdOEy/y3wlM3yRp+6SNQQ6xU0mmZcwRSriqk+et/cwWAtwmIGf6WkoDN2EK/AMdCO/dfXzIwi+rFMrjjQ==",
+      "version": "5.28.4",
+      "resolved": "https://registry.npmjs.org/undici/-/undici-5.28.4.tgz",
+      "integrity": "sha512-72RFADWFqKmUb2hmmvNODKL3p9hcB6Gt2DOQMis1SEBaV6a4MH8soBvzg+95CYhCKPFedut2JY9bMfrDl9D23g==",
       "dependencies": {
         "@fastify/busboy": "^2.0.0"
       },

src/handler/mask.js

@@ -9,13 +9,7 @@ const { GithubActions } = require('../githubActions');
  * @returns {(response: axios.AxiosResponse) => void}
  */
 const createMaskHandler = (actions) => (response) => {
-    let data = response.data
-
-    if (typeof data == 'object') {
-        data = JSON.stringify(data)
-    }
-
-    actions.setSecret(data)
+    actions.setSecret(JSON.stringify(response.data))
 }
 
 module.exports = { createMaskHandler }

src/handler/output.js

@@ -9,7 +9,7 @@ const { GithubActions } = require('../githubActions');
  * @returns {(response: axios.AxiosResponse) => void}
  */
 const createOutputHandler  = (actions) => (response) => {
-    actions.setOutput('response', response.data)
+    actions.setOutput('response', JSON.stringify(response.data))
     actions.setOutput('headers', response.headers)
 }
 

src/helper.js

@@ -55,7 +55,7 @@ const retry = async (callback, options) => {
       lastErr = err;
     }
 
-    if (i < options.retries) {
+    if (i < options.retry) {
       options.actions.warning(`#${i + 1} request failed: ${err}`);
       await sleep(options.sleep);
     }

src/httpClient.js

@@ -94,10 +94,10 @@ const request = async({ method, instanceConfig, data, files, file, actions, opti
       } catch(error) {
         if (error.response && options.ignoredCodes.includes(error.response.status)) {
           actions.warning(`ignored status code: ${JSON.stringify({ code: error.response.status, message: error.response.data })}`)
-          
-          return null
+
+          return error.response
         }
-        
+
         if (!error.response && error.request && options.preventFailureOnNoResponse) {
           actions.warning(`no response received: ${JSON.stringify(error)}`);
 

src/index.js

@@ -29,6 +29,9 @@ if (!!core.getInput('bearerToken')) {
 
 /** @type {axios.AxiosRequestConfig} */
 const instanceConfig = {
+  httpsAgent: new https.Agent({
+    rejectUnauthorized: core.getInput('ignoreSsl') !== 'true',
+  }),
   baseURL: core.getInput('url', { required: true }),
   timeout: parseInt(core.getInput('timeout') || 5000, 10),
   headers: { ...headers, ...customHeaders }
@@ -58,7 +61,7 @@ if (!!core.getInput('retry')) {
 
 let retryWait = 3000
 if (!!core.getInput('retryWait')) {
-  retry = parseInt(core.getInput('retryWait'))
+  retryWait = parseInt(core.getInput('retryWait'))
 }
 
 const data = core.getInput('data') || '{}';
@@ -102,4 +105,4 @@ request({ data, method, instanceConfig, files, file, actions, options }).then(re
   if (response && typeof response == 'object') {
     handler.forEach(h => h(response))
   }
-})
+})